16 add new extension methods#26
Draft
junc-nf wants to merge 4 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
Easy-Core/Extensions/AttributeExtensions.cs:140
- GetPropertyAttribute<TModel, TAttribute> assumes property.Body is always a MemberExpression and casts directly. For common expressions that include a conversion (e.g., value-type member lifted to object), property.Body becomes a UnaryExpression and this will throw InvalidCastException at runtime. Consider handling UnaryExpression (similar to GeneralExtensions.GetExpressionPropertyName) and returning null when the expression isn't a member access.
public static TAttribute? GetPropertyAttribute<TModel, TAttribute>(this Expression<Func<TModel>> property) where TAttribute : Attribute
{
var expression = (MemberExpression)property.Body;
var attribute = expression.Member.GetCustomAttribute(typeof(TAttribute)) as TAttribute;
Comment on lines
+245
to
+246
| if (step == 0) | ||
| yield break; |
Contributor
Author
There was a problem hiding this comment.
Doesn't seem necessary? Need confirmation from @thirstyape
Comment on lines
+260
to
+261
| if (step == 0) | ||
| yield break; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.